[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 10/14] qom: catch errors in object_property_
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [RFC PATCH 10/14] qom: catch errors in object_property_add_child |
Date: |
Wed, 11 Dec 2013 13:44:41 +0100 |
On Wed, 11 Dec 2013 13:19:17 +0100
Paolo Bonzini <address@hidden> wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> qom/object.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index fc19cf6..68fe07a 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -988,17 +988,22 @@ static void object_finalize_child_property(Object *obj,
> const char *name,
> void object_property_add_child(Object *obj, const char *name,
> Object *child, Error **errp)
> {
> + Error *local_err = NULL;
> gchar *type;
>
> type = g_strdup_printf("child<%s>", object_get_typename(OBJECT(child)));
>
> object_property_add(obj, name, type, object_get_child_property,
> - NULL, object_finalize_child_property, child, errp);
> -
> + NULL, object_finalize_child_property, child,
> &local_err);
> + if (error_is_set(&local_err)) {
> + error_propagate(errp, local_err);
> + goto out;
> + }
> object_ref(child);
> g_assert(child->parent == NULL);
> child->parent = obj;
>
> +out:
> g_free(type);
> }
>
> --
> 1.8.4.2
>
>
>
Reviewed-By: Igor Mammedov <address@hidden>
--
Regards,
Igor
- [Qemu-devel] [RFC PATCH 04/14] NUMA: convert -numa option to use OptsVisitor, (continued)
- [Qemu-devel] [RFC PATCH 04/14] NUMA: convert -numa option to use OptsVisitor, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 05/14] NUMA: expand MAX_NODES from 64 to 128, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 06/14] qapi: add SIZE type parser to string_input_visitor, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 07/14] QemuOpts: introduce qemu_find_opts_singleton, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 08/14] vl: convert -m to QemuOpts, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 09/14] qom: fix leak for objects created with -object, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 10/14] qom: catch errors in object_property_add_child, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 11/14] pc: pass QEMUMachineInitArgs to pc_memory_init, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 12/14] numa: introduce memory_region_allocate_system_memory, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 13/14] add memdev backend infrastructure, Paolo Bonzini, 2013/12/11
- [Qemu-devel] [RFC PATCH 14/14] numa: add -numa node, memdev= option, Paolo Bonzini, 2013/12/11