[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 3/5] exynos4210: Use macro ARRAY_SIZE where possi
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH v2 3/5] exynos4210: Use macro ARRAY_SIZE where possible |
Date: |
Sat, 7 Dec 2013 14:48:06 +0100 |
This improves readability and simplifies the code.
Cc: Dmitry Solodkiy <address@hidden>
Cc: Evgeny Voevodin <address@hidden>
Cc: Igor Mitsyanko <address@hidden>
Cc: Maksim Kozlov <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
hw/char/exynos4210_uart.c | 6 ++----
hw/misc/exynos4210_pmu.c | 3 +--
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c
index eef23a0..19b59cc 100644
--- a/hw/char/exynos4210_uart.c
+++ b/hw/char/exynos4210_uart.c
@@ -192,10 +192,9 @@ typedef struct Exynos4210UartState {
static const char *exynos4210_uart_regname(hwaddr offset)
{
- int regs_number = sizeof(exynos4210_uart_regs) / sizeof(Exynos4210UartReg);
int i;
- for (i = 0; i < regs_number; i++) {
+ for (i = 0; i < ARRAY_SIZE(exynos4210_uart_regs); i++) {
if (offset == exynos4210_uart_regs[i].offset) {
return exynos4210_uart_regs[i].name;
}
@@ -544,10 +543,9 @@ static void exynos4210_uart_event(void *opaque, int event)
static void exynos4210_uart_reset(DeviceState *dev)
{
Exynos4210UartState *s = EXYNOS4210_UART(dev);
- int regs_number = sizeof(exynos4210_uart_regs)/sizeof(Exynos4210UartReg);
int i;
- for (i = 0; i < regs_number; i++) {
+ for (i = 0; i < ARRAY_SIZE(exynos4210_uart_regs); i++) {
s->reg[I_(exynos4210_uart_regs[i].offset)] =
exynos4210_uart_regs[i].reset_value;
}
diff --git a/hw/misc/exynos4210_pmu.c b/hw/misc/exynos4210_pmu.c
index cbf0795..5ec14d1 100644
--- a/hw/misc/exynos4210_pmu.c
+++ b/hw/misc/exynos4210_pmu.c
@@ -383,8 +383,7 @@ static const Exynos4210PmuReg exynos4210_pmu_regs[] = {
{"GPS_ALIVE_OPTION", GPS_ALIVE_OPTION, 0x00000001},
};
-#define PMU_NUM_OF_REGISTERS \
- (sizeof(exynos4210_pmu_regs) / sizeof(Exynos4210PmuReg))
+#define PMU_NUM_OF_REGISTERS ARRAY_SIZE(exynos4210_pmu_regs)
#define TYPE_EXYNOS4210_PMU "exynos4210.pmu"
#define EXYNOS4210_PMU(obj) \
--
1.7.10.4
- [Qemu-devel] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array), Stefan Weil, 2013/12/07
- [Qemu-devel] [PATCH v2 2/5] ui/cocoa: Use macro A RRAY_SIZE where possible, Stefan Weil, 2013/12/07
- [Qemu-devel] [PATCH v2 1/5] misc: Use macro ARRAY_SIZE where possible, Stefan Weil, 2013/12/07
- [Qemu-devel] [PATCH v2 5/5] linux-user: Use macro TARGET_NSIG_WORDS where possible, Stefan Weil, 2013/12/07
- [Qemu-devel] [PATCH v2 3/5] exynos4210: Use macro ARRAY_SIZE where possible,
Stefan Weil <=
- [Qemu-devel] [PATCH v2 4/5] target-mips: Use macro ARRAY_SIZE where possible, Stefan Weil, 2013/12/07
- Re: [Qemu-devel] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array), Peter Maydell, 2013/12/07
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array), Michael Tokarev, 2013/12/07