[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names b
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states. |
Date: |
Fri, 6 Dec 2013 11:52:15 -0500 |
On Fri, 06 Dec 2013 08:24:33 -0700
Eric Blake <address@hidden> wrote:
> On 12/06/2013 07:27 AM, Luiz Capitulino wrote:
> > On Thu, 5 Dec 2013 18:15:00 +0100
> > Benoît Canet <address@hidden> wrote:
>
> >> -{ 'command': 'block_passwd', 'data': {'device': 'str', 'password': 'str'}
> >> }
> >> +{ 'command': 'block_passwd', 'data': {'*device': 'str',
> >> + '*node-name': 'str', 'password':
> >> 'str'} }
> >
> > What about:
> >
> > { 'command': 'block_passwd', 'data': {'device': 'str',
> > '*device-is-node': 'bool',
> > 'password': 'str'} }
>
> That would also work; the naming is a bit more awkward, but then you
> don't have the issue of mutually-exclusive optional arguments where
> exactly one of the two arguments is required.
Yes, and I dislike that very much.
Btw, can anyone remind me why we can't have new commands instead?
> I'm leaning slightly towards the approach that Benoît took, if only for
> the naming aspect (that is, I also thought of the idea of a bool flag,
> but didn't suggest it because I didn't like the implications on the
> naming). But I can live with either approach, if anyone else has a
> strong opinion.
Well, we can pick up any descriptive name 'treat-device-as-a-node',
'device-is-a-graph-node'...
- [Qemu-devel] [PATCH V4 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph., (continued)
- [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Benoît Canet, 2013/12/05
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Luiz Capitulino, 2013/12/06
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Eric Blake, 2013/12/06
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states.,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Benoît Canet, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Kevin Wolf, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Luiz Capitulino, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Benoît Canet, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Luiz Capitulino, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Benoît Canet, 2013/12/09
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Kevin Wolf, 2013/12/10
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Luiz Capitulino, 2013/12/10
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Kevin Wolf, 2013/12/10
- Re: [Qemu-devel] [PATCH V4 4/7] qmp: Allow to change password on names block driver states., Luiz Capitulino, 2013/12/10