[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/12] target-arm: A64: add support for B and BL insns |
Date: |
Thu, 05 Dec 2013 11:29:52 +1300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/05/2013 11:14 AM, Peter Maydell wrote:
> On 4 December 2013 21:55, Richard Henderson <address@hidden> wrote:
>> On 12/05/2013 08:33 AM, Peter Maydell wrote:
>>> @@ -680,6 +720,7 @@ void gen_intermediate_code_internal_a64(ARMCPU *cpu,
>>> dc->condjmp = 0;
>>>
>>> dc->aarch64 = 1;
>>> + dc->tmp_a64_count = 0;
>>> dc->thumb = 0;
>>> dc->bswap_code = 0;
>>> dc->condexec_mask = 0;
>>
>> Still no initialization of ->tmp_a64[]?
>
> It doesn't need initialization, does it? It's a static array, and we
> fill it as new temps are requested. So all we need to do is clear
> the count so it starts "empty". Or have I missed something?
Well, barring bugs, no.
But I suggested clearing to TCGV_UNUSED for --enable-tcg-debug at minimum so as
to catch those.
r~
[Qemu-devel] [PATCH v2 10/12] target-arm: A64: add support for conditional branches, Peter Maydell, 2013/12/04
[Qemu-devel] [PATCH v2 11/12] target-arm: A64: add support for 'test and branch' imm, Peter Maydell, 2013/12/04
[Qemu-devel] [PATCH v2 02/12] target-arm: A64: add set_pc cpu method, Peter Maydell, 2013/12/04
[Qemu-devel] [PATCH v2 06/12] target-arm: A64: provide skeleton for a64 insn decoding, Peter Maydell, 2013/12/04
[Qemu-devel] [PATCH v2 04/12] target-arm: Support fp registers in gdb stub, Peter Maydell, 2013/12/04
[Qemu-devel] [PATCH v2 12/12] target-arm: A64: add support for compare and branch imm, Peter Maydell, 2013/12/04