Re: [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches

[Richard Henderson]

On 12/04/2013 10:51 AM, Peter Maydell wrote:
> +    if (cond < 0x0e) {
> +        /* genuinely conditional branches */
> +        int label_nomatch = gen_new_label();
> +        arm_gen_test_cc(cond ^ 1, label_nomatch);
> +        gen_goto_tb(s, 0, addr);
> +        gen_set_label(label_nomatch);
> +        gen_goto_tb(s, 1, s->pc);

Why swap the condition with "^ 1"?  You can just as easily swap the goto_tb.  I
realize the A32 translator does it this way, but need we continue?

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~