[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotes
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py |
Date: |
Tue, 3 Dec 2013 15:27:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Tuesday 03 Dec 2013 à 16:25:23 (+0800), Fam Zheng a écrit :
> This will allow overriding cache mode from the "-c mode" option.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index fb10ff4..c84a1a5 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -37,6 +37,7 @@ qemu_args = os.environ.get('QEMU', 'qemu').strip().split('
> ')
> imgfmt = os.environ.get('IMGFMT', 'raw')
> imgproto = os.environ.get('IMGPROTO', 'file')
> test_dir = os.environ.get('TEST_DIR', '/var/tmp')
> +cachemode = os.environ.get('CACHEMODE')
+cachemode = os.environ.get('CACHEMODE', "none")
This way the default would be preserved.
>
> socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
>
> @@ -96,7 +97,7 @@ class VM(object):
> '''Add a virtio-blk drive to the VM'''
> options = ['if=virtio',
> 'format=%s' % imgfmt,
> - 'cache=none',
> + 'cache=%s' % cachemode,
> 'file=%s' % path,
> 'id=drive%d' % self._num_drives]
> if opts:
> --
> 1.8.4.2
>
>
- [Qemu-devel] [PATCH v5 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback", Fam Zheng, 2013/12/03
- [Qemu-devel] [PATCH v5 1/6] qemu-iotests: Add "-c <cache-mode>" option, Fam Zheng, 2013/12/03
- [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py, Fam Zheng, 2013/12/03
- Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py,
Benoît Canet <=
- [Qemu-devel] [PATCH v5 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes, Fam Zheng, 2013/12/03
- [Qemu-devel] [PATCH v5 4/6] qemu-iotests: Change default cache mode to "writeback", Fam Zheng, 2013/12/03
- [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Clean up spaces in usage output, Fam Zheng, 2013/12/03
- [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Split qcow2 only cases in 048, Fam Zheng, 2013/12/03