Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

[Markus Armbruster]

Peter Crosthwaite <address@hidden> writes:

> On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster <address@hidden> wrote:
>> Peter Crosthwaite <address@hidden> writes:
[...]
>>> @@ -3376,8 +3377,9 @@ int main(int argc, char **argv, char **envp)
>>>                  }
>>>
>>>                  qemu_opt_set_bool(fsdev, "readonly",
>>> -                                qemu_opt_get_bool(opts, "readonly", 0));
>>> -                device = qemu_opts_create_nofail(qemu_find_opts("device"));
>>> +                                  qemu_opt_get_bool(opts, "readonly", 0));
>>
>> Spurious whitespace change, please fix.
>>
>
> Is the change incorrect? I just did it as it was right next to my
> change and corrects relative to the local formatting.
>
> Regards,
> Peter

Ah, it was an intentional indentation fix, not an editing accident!
Your choice (I guess I'd refrain from it myself).

>>> +                device = qemu_opts_create(qemu_find_opts("device"), NULL, 
>>> 1,
>>> +                                          &error_abort);
>>>                  qemu_opt_set(device, "driver", "virtio-9p-pci");
>>>                  qemu_opt_set(device, "fsdev",
>>>                               qemu_opt_get(opts, "mount_tag"));
[...]