Re: [Qemu-devel] [PATCH v2] block: Close backing file early in bdrv_img_create

[Kevin Wolf]

Am 29.11.2013 um 21:41 hat Max Reitz geschrieben:
> Leaving the backing file open although it is not needed anymore can
> cause problems if it is opened through a block driver which allows
> exclusive access only and if the create function of the block driver
> used for the top image (the one being created) tries to close and reopen
> the image file (which will include opening the backing file a second
> time).
> 
> In particular, this will happen with a backing file opened through
> qemu-nbd and using qcow2 as the top image file format (which reopens the
> image to flush it to disk).
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
> v2:
>  - Minimizing the changes prevents introducing a leak of the
>    BlockDriverState in case of an error in bdrv_open() (thanks, Kevin).

Reviewed-by: Kevin Wolf <address@hidden>