qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 1/5] hw/ptimer: add VMSTATE_PTIMER_ARRAY


From: Li Guang
Subject: Re: [Qemu-devel] [PATCH v6 1/5] hw/ptimer: add VMSTATE_PTIMER_ARRAY
Date: Mon, 02 Dec 2013 12:28:11 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1.16) Gecko/20120421 Iceape/2.0.11

Peter Maydell wrote:
On 29 November 2013 11:01, Peter Maydell<address@hidden>  wrote:
On 27 November 2013 08:23, liguang<address@hidden>  wrote:
Signed-off-by: liguang<address@hidden>
---
  include/hw/ptimer.h |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
index 28fcaf1..a9b8f1d 100644
--- a/include/hw/ptimer.h
+++ b/include/hw/ptimer.h
@@ -27,6 +27,9 @@ void ptimer_stop(ptimer_state *s);

  extern const VMStateDescription vmstate_ptimer;

+#define VMSTATE_PTIMER_ARRAY(_f, _s, _n) \
+    VMSTATE_STRUCT_ARRAY(_f, _s, _n, 0, vmstate_ptimer, ptimer_state*)
The final parameter here should just be the struct type
("ptimer_state"), not a pointer-to-it.
Actually, looking at the patch where you've used this,
you do actually want to deal with an
array-of-pointers-to-ptimers. For that you need

#define VMSTATE_PTIMER_ARRAY(_f, _s, _n) \
     VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_ptimer, ptimer_state *)

(compare VMSTATE_TIMER_ARRAY in vmstate.h)



OK, thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]