Re: [Qemu-devel] [PATCH] configure: fix ambiguous 'DTC not present' message

[Peter Crosthwaite]

On Wed, Nov 27, 2013 at 6:12 PM, Antony Pavlov <address@hidden> wrote:
> The word "DTC" (device tree compiler) sometimes
> sounds ambiguous.
>
> "DTC not present" sounds like "dt compiler
> not present" but QEMU does not need the dt compiler
> itself but only libfdt library from DTC distribution.
>
> The phrase "Install the DTC devel package" seems
> confusing as dt compiler is a development tool itself.
> In the Debian distribution there are separate
> 'libfdt' and 'device-tree-compiler' packages;
> moreover the Debian 'device-tree-compiler' package
> does not depend on libfdt.

Thanks. I must confess I didn't to a lot of terminology research when
I added this probe.

>
> Signed-off-by: Antony Pavlov <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0666228..1384bc3 100755
> --- a/configure
> +++ b/configure
> @@ -2626,8 +2626,8 @@ EOF
>      fdt_libs="-L\$(BUILD_DIR)/dtc/libfdt $fdt_libs"
>    elif test "$fdt" = "yes" ; then
>      # have neither and want - prompt for system/submodule install
> -    error_exit "DTC not present. Your options:" \
> -        "  (1) Preferred: Install the DTC devel package" \
> +    error_exit "libfdt not present. Your options:" \
> +        "  (1) Preferred: Install the libfdt devel package" \
>          "  (2) Fetch the DTC submodule, using:" \
>          "      git submodule update --init dtc"
>    else
> --
> 1.8.4.4
>
>