[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDri
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState |
Date: |
Tue, 26 Nov 2013 19:05:05 +0800 |
On Tue, Nov 26, 2013 at 6:41 PM, Paolo Bonzini <address@hidden> wrote:
> Il 26/11/2013 11:31, Fam Zheng ha scritto:
>>> > I would just use an uint64_t, I think you have ~20 operations now.
>>> > There is still quite some breathing room.
>>> >
>> OK. Then, can we still use QAPI enum? Because I think being possible
>> to query blockers makes sense, that way the user doesn't have to trial
>> and error to know what operation is blocked.
>
> Yes, we can. You would still have to add a bunch of
>
> #define BLOCK_OPERATION_MASK_RESIZE (1ULL << BLOCK_OPERATION_TYPE_RESIZE)
>
> in block.h.
>
Well that works, but then we have a repeated list of operations in two
places, I'm not sure that would be good to have.
Kevin, Stefan, any opinion?
Fam
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, (continued)
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Stefan Hajnoczi, 2013/11/22
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Kevin Wolf, 2013/11/25
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Kevin Wolf, 2013/11/25
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2013/11/25
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Paolo Bonzini, 2013/11/26
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2013/11/26
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Paolo Bonzini, 2013/11/26
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2013/11/26
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState, Paolo Bonzini, 2013/11/26
- Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState,
Fam Zheng <=
[Qemu-devel] [PATCH v4 3/7] block: Replace in_use with operation blocker, Fam Zheng, 2013/11/22
[Qemu-devel] [PATCH v4 4/7] block: Add checks of blocker in block operations, Fam Zheng, 2013/11/22
[Qemu-devel] [PATCH v4 5/7] block: Parse "backing" option to reference existing BDS, Fam Zheng, 2013/11/22
[Qemu-devel] [PATCH v4 6/7] qmp: add command 'blockdev-backup', Fam Zheng, 2013/11/22