|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib < 2.22 |
Date: | Tue, 26 Nov 2013 06:24:53 +1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/25/2013 09:48 PM, Michael S. Tsirkin wrote: > g_string_vprintf was only introduced in 2.24 so switch to vsnprintf > instead. A bit uglier but name size is fixed at 4 bytes here so it's > easy. You list 2.24 here, > - GString *s = g_string_new(""); > + /* It would be nicer to use g_string_vprintf but it's only there in 2.22 > */ ... 2.22 here. But https://developer.gnome.org/glib/2.28/glib-Strings.html#g-string-vprintf says "since 2.14". > + char s[] = "XXXX"; char s[5]; Initializing it is a waste of time. r~
[Prev in Thread] | Current Thread | [Next in Thread] |