[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug i
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface |
Date: |
Mon, 25 Nov 2013 14:42:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 21/11/2013 03:38, Igor Mammedov ha scritto:
> + // 64-bit math: MAX = MIN + LEN - 1
> + Add(MINL, LENL, MAXL)
> + Add(MINH, LENH, MAXH)
> + If (Or(LLess(MAXL, MINL), LLess(MAXL, LENL))) {
The Or is not necessary, LLess(MAXL, MINL) is enough.
> + Add(MAXH, 1, MAXH)
One? (Just for consistency, iasl does it already).
> + }
> + // Ignore (MAXL == 0 & MAXH == 0) case
> + If (LEqual(MAXL, Zero)) {
> + Subtract(MAXH, One, MAXH)
> + Store(0xFFFFFFFF, MAXL)
> + } Else {
> + Subtract(MAXL, One, MAXL)
> + }
> +
Why not this:
If (LLess(MAXL, One)) {
Subtract(MAXH, One, MAXH)
}
Subtract(MAXL, One, MAXL)
Paolo
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, (continued)
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Gerd Hoffmann, 2013/11/22
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Gerd Hoffmann, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/25
[Qemu-devel] [PATCH 22/27] pc: add memory hotplug Q35 machine, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 24/27] pc: ACPI BIOS: add ssdt-mem.hex.generated and update ssdt-misc.hex.generated, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 25/27] pc: ACPI BIOS: use enum for defining memory affinity flags, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 26/27] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 27/27] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines, Igor Mammedov, 2013/11/20
Re: [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug, Michael S. Tsirkin, 2013/11/21