[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine |
Date: |
Thu, 21 Nov 2013 15:13:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 21.11.2013 06:48, schrieb Li Guang:
> Hi, Igor
>
> Igor Mammedov wrote:
>> Add DimmBus for memory hotplug below 4Gb or above 4Gb depending
>> on initial memory size and hotplug memory size.
>>
> ...
>> +static
>> +void pc_hotplug_memory_init_impl(Object *owner,
>> + MemoryRegion *system_memory,
>> + ram_addr_t low_hotplug_mem_start,
>> + ram_addr_t low_hotplug_mem_end,
>> + DimmBus *hotplug_mem_bus,
>> + ram_addr_t *high_mem_end)
>> +{
>> + QemuOpts *opts = qemu_opts_find(qemu_find_opts("memory-opts"),
>> NULL);
>> + ram_addr_t ram_size = qemu_opt_get_size(opts, "mem", 0);
>> + ram_addr_t maxmem = qemu_opt_get_size(opts, "maxmem", 0);
>> + ram_addr_t hotplug_mem_size;
>> +
>> + if (maxmem<= ram_size) {
>> + /* Disable ACPI migration code and creation of memory devices
>> in SSDT */
>>
>
> Why not give the memory that not be hot-added a chance to be placed on
> one memory slot?
Seconded, I believe I requested that on the previous version already.
Andreas
> if all memory can be hot-added and hot-removed, then we can bring in
> more flexibility for
> memory hotplug feature.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH 17/27] acpi: initialize memory hotplug ACPI ICH9 hardware, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 18/27] acpi: ich9: add memory-hotplug-io-base property to ich9_pm, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 20/27] pc: piix: make PCII440FXState type public, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 19/27] acpi: piix4/ich9: add optional vmstate field for MemHotplugState migration, Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/20
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Li Guang, 2013/11/21
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/21
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Michael S. Tsirkin, 2013/11/21
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Andreas Färber, 2013/11/21
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Michael S. Tsirkin, 2013/11/21
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Andreas Färber, 2013/11/25
- Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Igor Mammedov, 2013/11/26
Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine, Gerd Hoffmann, 2013/11/22