qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE S

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME
Date: Wed, 20 Nov 2013 15:19:57 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 
Il 20/11/2013 15:18, Stefan Hajnoczi ha scritto:
>> > +    if (buffer_is_zero(inbuf, s->qdev.blocksize)) {
> Where is inbuf's size checked?  It must be s->qdev.blocksize for this
> code to be correct.
> 

See scsi_req_length:

    case WRITE_SAME_10:
    case WRITE_SAME_16:
        cmd->xfer = dev->blocksize;
        break;

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]