[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info |
|
Date: |
Wed, 20 Nov 2013 13:39:48 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 19, 2013 at 06:07:30PM +0100, Paolo Bonzini wrote:
> +static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
> +{
> + BDRVVHDXState *s = bs->opaque;
> +
> + bdi->cluster_size =
> + (s->logical_sector_size / BDRV_SECTOR_SIZE) * s->block_size;
I thought s->block_size is in bytes. Why multiply by the logical block
size in 512-byte sectors?
Stefan
[Qemu-devel] [PATCH v2 10/20] block/iscsi: remove .bdrv_has_zero_init, Paolo Bonzini, 2013/11/19
[Qemu-devel] [PATCH v2 09/20] block drivers: expose requirement for write same alignment from formats, Paolo Bonzini, 2013/11/19
[Qemu-devel] [PATCH v2 11/20] block/iscsi: updated copyright, Paolo Bonzini, 2013/11/19
[Qemu-devel] [PATCH v2 12/20] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP, Paolo Bonzini, 2013/11/19
[Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1, Paolo Bonzini, 2013/11/19