Re: [Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage

[Stefan Hajnoczi]

On Mon, Nov 18, 2013 at 03:55:45PM -0000, Varad wrote:
> Incomplete patch.
> 
> Usecase: `qemu-img convert` with -p now shows the write speed.
> 
> 1. I'm calculating the speed using the time taken to run the for(;;)
> at qemu-img.c:1477. I figured that every time this loop runs, n1
> sectors are converted, and so I calculate the write_speed
> accordingly. Is this correct?
> 
> 2. I have changed qemu-progress.c:qemu_progress_print() to take in a
> speed parameter, thinking that it would be the best option. Should I
> do it some other way instead (maybe write another function to print
> just speed)?
> 
> ** Patch added: "[PATCH/RFC]"
>    
> https://bugs.launchpad.net/qemu/+bug/603872/+attachment/3911803/+files/0001-qemu-img-show-image-conversion-speed.patch

Patches attached on the bug tracker are not reviewed, they should be
sent to the qemu-devel mailing list instead.

If you want to link to a submitted patch from launchpad, please post a
mailing list archive link.  For example:
http://article.gmane.org/gmane.comp.emulators.qemu/242109