[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V2 2/8] qapi script: add check for duplicated key
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V2 2/8] qapi script: add check for duplicated key |
Date: |
Wed, 13 Nov 2013 06:25:02 +0800 |
It is bad that same key was specified twice, especially when a union have
two branches with same condition. This patch can prevent it.
Signed-off-by: Wenchao Xia <address@hidden>
---
scripts/qapi.py | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index 82f586e..aa91edc 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -116,6 +116,8 @@ class QAPISchema:
if self.tok != ':':
raise QAPISchemaError(self, 'Expected ":"')
self.accept()
+ if key in expr:
+ raise QAPISchemaError(self, 'Duplicated key "%s"' % key)
expr[key] = self.get_expr(True)
if self.tok == '}':
self.accept()
--
1.7.1
- [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 2/8] qapi script: add check for duplicated key,
Wenchao Xia <=
- [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 1/8] qapi script: remember enum values, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 3/8] qapi script: check correctness of discriminator values in union, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 7/8] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 4/8] qapi script: code move for generate_enum_name(), Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 6/8] qapi script: not generate hidden enum type for pre-defined enum discriminator, Wenchao Xia, 2013/11/13
- [Qemu-devel] [PATCH V2 8/8] tests: add cases for inherited struct and union with discriminator, Wenchao Xia, 2013/11/13
- Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2013/11/13
- Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name, Luiz Capitulino, 2013/11/25