[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helpe
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] build: set up capabilities on qemu-bridge-helper |
|
Date: |
Tue, 12 Nov 2013 12:23:21 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/12/2013 04:10 AM, Avi Kivity wrote:
> Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper since
> it doesn't have the required capabilities.
>
> Fix by adding them.
>
> Note: this may break installing as non-root. This is actually the right
> thing to do, since not setting up the capability would result in a broken
> setup. Perhaps we need a configure flag to disable helpers.
>
> +++ b/rules.mak
> @@ -177,3 +177,5 @@ $(shell mkdir -p $(sort $(foreach
> var,$(nested-vars),$(dir $($(var))))))
> $(foreach var,$(nested-vars), $(eval \
> -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
> endef
> +
> +SETCAP = setcap
> \ No newline at end of file
Is this intentional?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature