|
From: | Wenchao Xia |
Subject: | Re: [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritance for struct |
Date: | Thu, 07 Nov 2013 10:33:57 +0800 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
δΊ 2013/11/6 21:33, Eric Blake ει:
On 11/05/2013 08:20 PM, Wenchao Xia wrote:+ 'server': { + '_base': 'NetworkConnectionInfo',Interesting idea for shorthand. However, I would suggest that you pick a different character than '_', since '_' is valid in names. That is, we already have special handling of leading '*' to mark a field as optional, so I suggest something like '^' to mark a base class. By using a non-name character, it becomes more obvious that the leading character has a special meaning to the qapi generator. I'm also not convinced yet that we want this shorthand; in particular, I'm worried whether it will make the introspection patches harder to write.I am not sure about this approach either, so put RFC tag on it. The purpose is allow not to define structures that would be only used once. What instrospection patch do you mean? Python instrospection mechnism? You mean there is a python utility which recognize only keyword "base" now?No, I'm talking about Amos' patches to expose the qapi to the user via a QMP command. Last version proposed was here: https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg02494.html although with the addition of discriminated union types in the meantime, my understanding is Amos is planning on posting another version soon for the 1.8 timeframe.
I'll drop this patch now.
[Prev in Thread] | Current Thread | [Next in Thread] |