Re: [Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG

[Eric Blake]

On 11/06/2013 06:04 AM, Juan Quintela wrote:
> Instead of the bitmap, we use the bitmap number.  Once this is done,
> we change all names from dirty_flag to memory regions naming of
> client.
> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  cputlb.c                       |  4 ++--
>  exec.c                         | 18 +++++++++---------
>  include/exec/memory-internal.h | 38 +++++++++++++++++---------------------
>  include/exec/memory.h          |  3 ---
>  memory.c                       | 10 ++++------
>  5 files changed, 32 insertions(+), 41 deletions(-)
> 
> -
>  static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
> -                                                     int dirty_flag)
> +                                                      unsigned client)

Aha - you fixed the other whitespace nit I pointed out on 6/39.  Since
both nits were transient, it's not worth respinning that patch just for
whitespace.  And since my subsequent nits in commit headers could be
touched up by a maintainer when adding my Reviewed-by, you may have
escaped a respin if the rest of the series is clean :)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature