[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default |
Date: |
Wed, 6 Nov 2013 10:48:14 +0000 |
On 6 November 2013 09:18, Gerd Hoffmann <address@hidden> wrote:
> I think the audio backend handling needs a serious makeover. Detect
> sound libraries (pulse, esd, alsa, ...) via configure like any other
> library. Zap the whole can_be_default logic. Replace it by walking the
> list of backends, sorted by priority, take the first which initializes
> successfully.
I agree on the need for a serious overhaul. I think the thing we're
actually hitting at the moment is that none of the backends are
quiet when they fail to initialize, which is bad since we already have
"loop through and take first which initializes" logic.
> That is clearly 1.8 material though. I think for 1.7 we should simply
> leave things as-is.
Do you mean "as-is with Anthony's patch applied", or "as it was
before that patch was applied" ? I would suggest the latter
(ie revert this patch), because that's the safest choice this
close to release.
thanks
-- PMM
- [Qemu-devel] [PATCH] ossaudio: do not enable by default, Anthony Liguori, 2013/11/03
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Andreas Färber, 2013/11/03
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Gerd Hoffmann, 2013/11/04
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Anthony Liguori, 2013/11/05
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Peter Maydell, 2013/11/05
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Peter Maydell, 2013/11/05
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Gerd Hoffmann, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Gerd Hoffmann, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Anthony Liguori, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Peter Maydell, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Gerd Hoffmann, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Anthony Liguori, 2013/11/06
- Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Gerd Hoffmann, 2013/11/07
Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default, Peter Maydell, 2013/11/04