[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap |
Date: |
Mon, 04 Nov 2013 11:37:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 04/11/2013 10:30, Fam Zheng ha scritto:
> diff --git a/include/block/block.h b/include/block/block.h
> index 3560deb..06f424c 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -388,12 +388,15 @@ void *qemu_blockalign(BlockDriverState *bs, size_t
> size);
> bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov);
>
> struct HBitmapIter;
> -void bdrv_set_dirty_tracking(BlockDriverState *bs, int granularity);
> -int bdrv_get_dirty(BlockDriverState *bs, int64_t sector);
> +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap;
> +BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs, int
> granularity);
> +void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap
> *bitmap);
> +int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t
> sector);
> void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int
> nr_sectors);
> void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector, int
> nr_sectors);
> -void bdrv_dirty_iter_init(BlockDriverState *bs, struct HBitmapIter *hbi);
> -int64_t bdrv_get_dirty_count(BlockDriverState *bs);
> +void bdrv_dirty_iter_init(BlockDriverState *bs,
> + BdrvDirtyBitmap *bitmap, struct HBitmapIter *hbi);
> +int64_t bdrv_get_dirty_count(BlockDriverState *bs, BdrvDirtyBitmap *bitmap);
>
> void bdrv_enable_copy_on_read(BlockDriverState *bs);
> void bdrv_disable_copy_on_read(BlockDriverState *bs);
You do not really need the BDS argument to the functions, do you? (Or
do you have other plans?)
Apart from this, looks good.
Paolo
- [Qemu-devel] [PATCH v2] block: per caller dirty bitmap, Fam Zheng, 2013/11/04
- Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap, BenoƮt Canet, 2013/11/04
- Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap, Stefan Hajnoczi, 2013/11/11
- Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap, Stefan Hajnoczi, 2013/11/11
- Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap, Kevin Wolf, 2013/11/12