[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IM
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019 |
Date: |
Thu, 31 Oct 2013 11:00:49 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 |
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> There were still instances of $TEST_IMG not being properly quoted.
> This was in the usage of a string built up for a 'for' loop; modify
> the loop so we can quote $TEST_IMG properly.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> tests/qemu-iotests/019 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019
> index cd3582c..5bb18d0 100755
> --- a/tests/qemu-iotests/019
> +++ b/tests/qemu-iotests/019
> @@ -90,12 +90,12 @@ mv "$TEST_IMG" "$TEST_IMG.orig"
> # Test the conversion twice: One test with the old-style -B option and
> another
> # one with -o backing_file
>
> -for backing_option in "-B $TEST_IMG.base" "-o backing_file=$TEST_IMG.base";
> do
> +for backing_option in "-B " "-o backing_file="; do
>
> echo
> - echo Testing conversion with $backing_option | _filter_testdir |
> _filter_imgfmt
> + echo Testing conversion with $backing_option$TEST_IMG.base |
> _filter_testdir | _filter_imgfmt
If $TEST_IMG has 2 consecutive spaces [*], this echo produces spurious
output (flattening to only 1 space). To be completely robust, you must
quote here in the same manner...
> echo
> - $QEMU_IMG convert -O $IMGFMT $backing_option "$TEST_IMG.orig" "$TEST_IMG"
> + $QEMU_IMG convert -O $IMGFMT $backing_option"$TEST_IMG.base"
> "$TEST_IMG.orig" "$TEST_IMG"
...as what you execute. But as that corner case of misquoting doesn't
fail the test, your patch is a strict improvement, so I'm okay whether
you post a v2, or whether you keep this as-is and add:
Reviewed-by: Eric Blake <address@hidden>
[*] My favorite test for quoting bugs is renaming a directory to use
'two spaces', because some quoting bugs are missed when you only test
'one space'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] block: qemu-iotests, more quoting fixes, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 2/7] block: qemu-iotests, fix _make_test_img() to work with spaced pathnames, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 3/7] block: qemu-iotests, add quotes to $TEST_IMG.base usage in 017, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019, Jeff Cody, 2013/10/31
- Re: [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019,
Eric Blake <=
- [Qemu-devel] [PATCH 5/7] block: qemu-iotests, removes duplicate double quotes in 039, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 6/7] block: qemu-iotests, add quotes to $TEST_IMG usage for 051, Jeff Cody, 2013/10/31
- [Qemu-devel] [PATCH 7/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 061, Jeff Cody, 2013/10/31