Re: [Qemu-devel] [PATCH] import kvm-unittest in QEMU source tree

[Andrew Jones]

On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote:
> This simply imports kvm-unittest git into qemu source tree.
> 
> We can next work on making make check run it
> automatically.
> 
> Squashed 'kvm-unittest/' content from commit 2bc0e29
> 
> git-subtree-dir: kvm-unittest
> git-subtree-split: 2bc0e29ee4447bebcd3b90053881f59265306adc
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> ---
> 
> Gleb, Paolo, any objections to this?  I really want a small guest for
> running ACPI tests during make check, and kvm-unittest seems to fit the
> bill.
> 
> Ability to test e.g. PCI with this in-tree would be very benefitial.
>

Sorry for slow reply, I just noticed this mail now.

So far qemu is a dependency for kvm-unit-tests (both x86 and arm use it),
but at some point that could change (if another arch doesn't want to use
qemu). So if that happens, then it won't make much sense for the tests to
live in qemu. Thus I'm not 100% in favor of moving them. However, if the
consensus is to move them, then I have two comments on this patch.

1) There are a couple pendings patches on the kvm list that tidy up the
kvm-unit-tests repo - removing lots of the files. That should be
committed first to avoid importing a bunch of files right before deleting
them.

2) The name shouldn't change from kvm-unit-tests to kvm-unittest.

drew