Re: [Qemu-devel] [PATCH 13/24] ide: move retry constants out of BM_STATUS_* namespace

[Kevin Wolf]

Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/ide/core.c     | 20 ++++++++++----------
>  hw/ide/internal.h | 12 ++++++------
>  hw/ide/pci.c      | 14 +++++++-------
>  3 files changed, 23 insertions(+), 23 deletions(-)

> --- a/hw/ide/internal.h
> +++ b/hw/ide/internal.h
> @@ -485,12 +485,12 @@ struct IDEDevice {
>      uint64_t wwn;
>  };
>  
> -/* FIXME These are not status register bits */
> -#define BM_STATUS_DMA_RETRY  0x08
> -#define BM_STATUS_PIO_RETRY  0x10
> -#define BM_STATUS_RETRY_READ  0x20
> -#define BM_STATUS_RETRY_FLUSH 0x40
> -#define BM_STATUS_RETRY_TRIM 0x80
> +/* These are used for the error_status field of IDEBus */
> +#define IDE_RETRY_DMA  0x08
> +#define IDE_RETRY_PIO  0x10
> +#define IDE_RETRY_READ  0x20
> +#define IDE_RETRY_FLUSH 0x40
> +#define IDE_RETRY_TRIM 0x80

I wouldn't mind using the chance to align the numbers on the same
column (or at least removing one space where there are two)

Kevin