[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT |
Date: |
Wed, 30 Oct 2013 12:55:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 30/10/2013 08:27, Wenchao Xia ha scritto:
> δΊ 2013/10/30 2:18, Kevin Wolf ει:
>> Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
>>> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>>>> The define will be moved to qapi-schema.json later, so rename the
>>>> prefix to match its naming style.
>>> Wouldn't it be simpler to fix the code generator to special case QEvent
>>> to turn into QEVENT, instead of having to go through this churn? But if
>>> we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical:
>> Or rather, instead of special casing QEvent, it shouldn't insert
>> underscores if there is nothing between the two capital letters.
... but it should still insert one before the very last capital letter.
For example AIOType should become AIO_TYPE, not AIOTYPE.
>> I've had a similar case with AIO in the blockdev-add series; and while
>> renaming it to Aio worked, this kind of thing doesn't seem to be a rare
>> exception in practice, so it might be worth adjusting the generator.
>
> It seems the right way, will adjust the generator.
I think even if you adjusted it, it would be a no-op in this case. For
example:
AIOType => AIO_TYPE
QEvent => Q_EVENT
Paolo
- Re: [Qemu-devel] [PATCH 2/6] qapi: rename MonitorEvent to QEvent, (continued)
- [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Paolo Bonzini, 2013/10/28
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Eric Blake, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/30
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Kevin Wolf, 2013/10/29
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/30
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT, Wenchao Xia, 2013/10/31
[Qemu-devel] [PATCH 5/6] qapi: remove var monitor_event_names[], Wenchao Xia, 2013/10/21
[Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/21
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/23
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Eric Blake, 2013/10/29
- Re: [Qemu-devel] [PATCH 6/6] qapi: add doc for QEvent, Wenchao Xia, 2013/10/30