qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'


From: Michael R. Hines
Subject: Re: [Qemu-devel] [PATCH] rdma: rename 'x-rdma' => 'rdma'
Date: Fri, 25 Oct 2013 11:03:28 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 10/23/2013 02:25 AM, Paolo Bonzini wrote:
Il 22/10/2013 21:20, Eric Blake ha scritto:
-# @x-rdma-pin-all: Controls whether or not the entire VM memory footprint is
+# @rdma-pin-all: Controls whether or not the entire VM memory footprint is
  #          mlock()'d on demand or all at once. Refer to docs/rdma.txt for 
usage.
  #          Disabled by default. Experimental: may (or may not) be renamed 
after
  #          further testing is complete. (since 1.6)
I'd also recommend tweaking this to say 'since 1.7', since the spelling
'rdma-pin-all' is new to this release.
I would also leave this as experimental for now.

Basically the point of the "experimental" designation was to ensure that
RDMA protocol changes might not preserve backwards compatibility.  The
capability is a separate thing from the protocol, as it would likely
apply to any migration-over-RDMA implementation

Paolo


Well, I tried posting libvirt support with this naming scheme,
but they didn't accepted.

Their reason (Daniel, I think) is valid: experimental implies that it
shouldn't be exposed in the management software until it is
deemed stable at some point.

As far we can tell, it is stable, and made very clear using the new
'setup' state in the migration state machine.

How would we expose it in libvirt as an experimental feature
without labeling it as an experimental feature?

- Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]