qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/10] isa: Clean up use of cannot_instantiate_w


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 09/10] isa: Clean up use of cannot_instantiate_with_device_add_yet
Date: Thu, 24 Oct 2013 11:02:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Peter Maydell <address@hidden> writes:

> On 17 October 2013 14:55,  <address@hidden> wrote:
>> From: Markus Armbruster <address@hidden>
>>
>> Drop it when there's no obvious reason why device_add could not work.
>> Else keep and document why.
>>
>> * isa-fdc, port92, i8042, m48t59_isa, mc146818rtc, isa-pit, kvm-pit:
>>   drop (from the last two by dropping it from their abstract base
>>   pit-common)
>
> port92 needs its a20_out qemu_irq line wiring up, doesn't it?
>
> the pit devices have an output IRQ line that needs wiring up.

Good points; I'll have a second look at these two.  Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]