[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 3/8] sheepdog: reload inode outside of resend_aio
From: |
MORITA Kazutaka |
Subject: |
[Qemu-devel] [PATCH v5 3/8] sheepdog: reload inode outside of resend_aioreq |
Date: |
Thu, 24 Oct 2013 16:01:13 +0900 |
This prepares for using resend_aioreq() after reconnecting to the
sheepdog server.
Reviewed-by: Liu Yuan <address@hidden>
Signed-off-by: MORITA Kazutaka <address@hidden>
---
block/sheepdog.c | 33 +++++++++++++++++++--------------
1 file changed, 19 insertions(+), 14 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 59cad97..5569e54 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -222,6 +222,11 @@ static inline uint64_t data_oid_to_idx(uint64_t oid)
return oid & (MAX_DATA_OBJS - 1);
}
+static inline uint32_t oid_to_vid(uint64_t oid)
+{
+ return (oid & ~VDI_BIT) >> VDI_SPACE_SHIFT;
+}
+
static inline uint64_t vid_to_vdi_oid(uint32_t vid)
{
return VDI_BIT | ((uint64_t)vid << VDI_SPACE_SHIFT);
@@ -600,7 +605,7 @@ static int coroutine_fn add_aio_request(BDRVSheepdogState
*s, AIOReq *aio_req,
struct iovec *iov, int niov, bool create,
enum AIOCBState aiocb_type);
static int coroutine_fn resend_aioreq(BDRVSheepdogState *s, AIOReq *aio_req);
-
+static int reload_inode(BDRVSheepdogState *s, uint32_t snapid, const char
*tag);
static AIOReq *find_pending_req(BDRVSheepdogState *s, uint64_t oid)
{
@@ -748,6 +753,19 @@ static void coroutine_fn aio_read_response(void *opaque)
case SD_RES_SUCCESS:
break;
case SD_RES_READONLY:
+ if (s->inode.vdi_id == oid_to_vid(aio_req->oid)) {
+ ret = reload_inode(s, 0, "");
+ if (ret < 0) {
+ goto out;
+ }
+ }
+
+ if (is_data_obj(aio_req->oid)) {
+ aio_req->oid = vid_to_data_oid(s->inode.vdi_id,
+ data_oid_to_idx(aio_req->oid));
+ } else {
+ aio_req->oid = vid_to_vdi_oid(s->inode.vdi_id);
+ }
ret = resend_aioreq(s, aio_req);
if (ret == SD_RES_SUCCESS) {
goto out;
@@ -1185,19 +1203,6 @@ static int coroutine_fn resend_aioreq(BDRVSheepdogState
*s, AIOReq *aio_req)
{
SheepdogAIOCB *acb = aio_req->aiocb;
bool create = false;
- int ret;
-
- ret = reload_inode(s, 0, "");
- if (ret < 0) {
- return ret;
- }
-
- if (is_data_obj(aio_req->oid)) {
- aio_req->oid = vid_to_data_oid(s->inode.vdi_id,
- data_oid_to_idx(aio_req->oid));
- } else {
- aio_req->oid = vid_to_vdi_oid(s->inode.vdi_id);
- }
/* check whether this request becomes a CoW one */
if (acb->aiocb_type == AIOCB_WRITE_UDATA && is_data_obj(aio_req->oid)) {
--
1.7.10.4
- [Qemu-devel] [PATCH v5 0/8] sheepdog: reconnect server after connection failure, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 5/8] sheepdog: try to reconnect to sheepdog after network error, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 3/8] sheepdog: reload inode outside of resend_aioreq,
MORITA Kazutaka <=
- [Qemu-devel] [PATCH v5 6/8] sheepdog: make add_aio_request and send_aioreq void functions, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 1/8] sheepdog: check return values of qemu_co_recv/send correctly, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 7/8] sheepdog: cancel aio requests if possible, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 8/8] sheepdog: check simultaneous create in resend_aioreq, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 4/8] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers, MORITA Kazutaka, 2013/10/24
- [Qemu-devel] [PATCH v5 2/8] sheepdog: handle vdi objects in resend_aio_req, MORITA Kazutaka, 2013/10/24
- Re: [Qemu-devel] [PATCH v5 0/8] sheepdog: reconnect server after connection failure, Liu Yuan, 2013/10/28