qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [v2 07/13] Add VSX Scalar Move Instructions


From: Tom Musta
Subject: Re: [Qemu-devel] [v2 07/13] Add VSX Scalar Move Instructions
Date: Tue, 22 Oct 2013 07:57:14 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1

On 10/22/2013 1:31 AM, Paolo Bonzini wrote:
Il 11/10/2013 14:02, Tom Musta ha scritto:

+            case OP_CPSGN: {                                      \
+                TCGv_i64 xa = tcg_temp_new();                     \
+                tcg_gen_mov_i64(xa, cpu_vsrh(xA(ctx->opcode)));   \
+                tcg_gen_andi_i64(xa, xa, (sgn_mask));             \
+                tcg_gen_andi_i64(xb, xb, ~(sgn_mask));            \
+                tcg_gen_or_i64(xb, xb, xa);                       \
+                tcg_temp_free(xa);                                \
+                break;                                            \

You might get slightly better generated code if you move the sgn_mask
immediate to a temporary and then use and+andc.

Paolo

Thank you for the suggestion, Paolo.  I will recode, retest and resubmit this 
one and patch 8.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]