Re: [Qemu-devel] [RFC v5 4/5] hw/arm/digic: add UART support

[Antony Pavlov]

On Thu, 17 Oct 2013 18:54:28 +0100
Peter Maydell <address@hidden> wrote:

> On 7 September 2013 08:04, Antony Pavlov <address@hidden> wrote:
> > Signed-off-by: Antony Pavlov <address@hidden>
> > --- a/hw/arm/digic_boards.c
> > +++ b/hw/arm/digic_boards.c
> > @@ -26,6 +26,13 @@
> >  #include "hw/boards.h"
> >  #include "exec/address-spaces.h"
> >  #include "hw/arm/digic.h"
> > +#include "hw/block/flash.h"
> > +#include "hw/loader.h"
> > +#include "sysemu/sysemu.h"
> > +
> > +#define DIGIC4_ROM0_BASE      0xf0000000
> > +#define DIGIC4_ROM1_BASE      0xf8000000
> > +# define DIGIC4_ROM_MAX_SIZE      0x08000000
> 
> Stray extra spaces here. If you fix those then:
> Reviewed-by: Peter Maydell <address@hidden>

Yes, my bad!

But this fragment (defining DIGIC4_ROM* macros) is misplaced. It will go to the 
"add NOR ROM support" in the next patchseries version.


-- 
-- 
Best regards,
  Antony Pavlov