Then there's still the problem that I'm not the one who introduced
error_propagate. Someone obviously intended some purpose for it, so
even if it doesn't make a difference now (and my RFC is unneeded),
I'd still use it to propagate errors (instead of passing the error
pointer). My point being that there *is* a function for propagating
errors and I think we should therefore use it. The current qemu code
seems to alternate between the two alternatives, although using
error_propagate seems more common to me (at least, that was the
result when I looked through the code trying to decide whether to
use it or not).
Generally, we need a proper discussion about whether error_propagate
is obsolete or not. Afterwards, we can adapt the current codebase to
the result of that discussion; but until then, I oppose changing
existing code without actual need to do so but personal preference.
Max
PS: I wrote my error_propagate RFC in part because I was
disappointed about how much of a no-op error_propagate actually is
and was trying to change that. ;-)