[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks |
Date: |
Fri, 18 Oct 2013 15:50:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 18/10/2013 15:26, Peter Lieven ha scritto:
>>
>>
>> - bdrv_discard_zeroes for bdrv_has_discard_write_zeroes
> This would conform to the linux ioctl BLKDISCARDZEROES.
> However, we need the write_zeroes operation for a guarantee
> that zeroes are return.
Yes. I'm fine with the current names actually, just thinking loudly.
>> - bdrv_unallocated_blocks_are_zero for bdrv_has_discard_zeroes
>>
>> But I'm not sure why we have different BlockDriver APIs. I'd rather put
>> the new flags in BlockDriverInfo, and make the new functions simple
>> wrappers around bdrv_get_info. I think I proposed that before, maybe I
>> wasn't clear or I was misunderstood.
> I think Kevin wanted to have special functions for this.
Yes, but I think he referred to block.c functions not BlockDriver functions.
Paolo
- [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, (continued)
- [Qemu-devel] [PATCHv4 11/17] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 04/17] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 10/17] iscsi: set limits in BlockDriverState, Peter Lieven, 2013/10/08
- [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/08
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Stefan Hajnoczi, 2013/10/30
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/30
- Re: [Qemu-devel] [PATCHv4 14/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks, Peter Lieven, 2013/10/18
[Qemu-devel] [PATCHv4 12/17] iscsi: add bdrv_co_write_zeroes, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 13/17] block: introduce bdrv_make_zero, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 16/17] qemu-img: conditionally zero out target on convert, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 15/17] qemu-img: add support for fully allocated images, Peter Lieven, 2013/10/08
[Qemu-devel] [PATCHv4 17/17] block/raw: copy BlockLimits on raw_open, Peter Lieven, 2013/10/08