qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() suppo


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support
Date: Thu, 17 Oct 2013 16:07:51 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Oct 11, 2013 at 02:17:36PM -0400, Jeff Cody wrote:
> +    if (image_size > VHDX_MAX_IMAGE_SIZE) {
> +        fprintf(stderr, "Image size too large; max of 64TB\n");

Please use error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB") 
instead of fprintf().

There are other instances in this file that should be converted too.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]