[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() suppo
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support |
Date: |
Thu, 17 Oct 2013 16:07:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 11, 2013 at 02:17:36PM -0400, Jeff Cody wrote:
> + if (image_size > VHDX_MAX_IMAGE_SIZE) {
> + fprintf(stderr, "Image size too large; max of 64TB\n");
Please use error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB")
instead of fprintf().
There are other instances in this file that should be converted too.
- Re: [Qemu-devel] [PATCH v7 10/19] block: vhdx - add log write support, (continued)
- [Qemu-devel] [PATCH v7 11/19] block: vhdx write support, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 12/19] block: vhdx - remove BAT file offset bit shifting, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 13/19] block: vhdx - move more endian translations to vhdx-endian.c, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 14/19] block: vhdx - break out code operations to functions, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 15/19] block: vhdx - fix comment typos in header, fix incorrect struct fields, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support, Jeff Cody, 2013/10/11
- Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v7 17/19] block: vhdx - update _make_test_img() to filter out vhdx options, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 18/19] block: qemu-iotests for vhdx, add write test support, Jeff Cody, 2013/10/11
- [Qemu-devel] [PATCH v7 19/19] block: vhdx qemu-iotest - log replay of data sector, Jeff Cody, 2013/10/11
- Re: [Qemu-devel] [PATCH v7 00/19] VHDX log replay and write support, .bdrv_create(), Stefan Hajnoczi, 2013/10/18