Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

[Paolo Bonzini]

Il 17/10/2013 07:34, Michael S. Tsirkin ha scritto:
> > So we could have a qtest for sanity checking ACPI tables.  At least
> > fw_cfg is one of the few components that has qtest infrastructure...  I
> > don't think we need to do more than that though.  The set of sanity
> > checks can start with a simple list of tables that "have to be there"
> > for a given machine type.
> 
> Well this means these tests won't pass on old qemu so
> they would be useless for comparing old to new.

Yes, they would be correctness tests not compatibility tests.

> And in this case, while it's a good idea to have them
> I don't see why it's a blocker for merging.

In principle, correctness tests should be a prerequisite for merging
something.  Would you merge RCU without an equivalent of rcutorture?

We rarely if ever obey that principle, but we sometimes do (e.g. QAPI
has pretty good test cases, and new additions to util/ almost always get
new testcases these days).

Paolo