[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock |
|
Date: |
Wed, 16 Oct 2013 18:21:09 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote:
> This lock does not protect anything that the BQL does not already
> protect. Furthermore, with -nodefaults and no monitor, the mutex
> is not initialized but monitor_protocol_event_queue is called
> anyway, which causes a crash under mingw (and only works by luck.
> under Linux or other POSIX OSes).
>
> Reported-by: Orx Goshen <address@hidden>
> Cc: Daniel Berrange <address@hidden>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> Maybe I'm missing something?
ACK, I only added it because I wasn't clear on
wether the BQL was sufficient, so it was just a
safety net.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|