[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic |
|
Date: |
Tue, 15 Oct 2013 13:32:43 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 14/10/2013 18:45, Eduardo Habkost ha scritto:
> + if (field->field_exists && !field->field_exists(opaque, version_id))
> {
> + continue;
> + }
> + if (field->version_id > version_id) {
> + continue;
> + }
What Markus observed...
I think the change is fine because we currently never have field_exists
and version_id set for the same field.
However, I suggest to move the change to a separate patch, and swap the
two ifs in this one.
Paolo
- [Qemu-devel] [PATCH 0/5] vmstate: Add max_version_id field, Eduardo Habkost, 2013/10/14
- [Qemu-devel] [PATCH 1/5] savevm: Coding style line length fix, Eduardo Habkost, 2013/10/14
- [Qemu-devel] [PATCH 2/5] vmstate: Replace while (...) with for (...), Eduardo Habkost, 2013/10/14
- [Qemu-devel] [PATCH 5/5] vmstate: Add max_version_id field to VMStateDescription, Eduardo Habkost, 2013/10/14
- [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic, Eduardo Habkost, 2013/10/14
- [Qemu-devel] [PATCH 4/5] vmstate: Use version_id when saving, Eduardo Habkost, 2013/10/14