Re: [Qemu-devel] [PATCH v3] misc: Spelling and grammar fixes in comments

[Peter Maydell]

On 12 October 2013 05:03, Don Koch <address@hidden> wrote:
> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>> * it's -> its
>> * grammar fix in ui/vnc-enc-zywrle.h
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>
>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>>
>> v3:
>> Don't try to improve a strange sentence in the same context ("Of cause 
>> [...]").

>>   In this method, H/L and X0/X1 is always same position.
>> - This lead us to more speed and less memory.
>> + This leads us to more speed and less memory.
>>   Of cause, the result of both method is quite same
>>   because it's only difference that coefficient position.
>>  */
>>
>
> Since you're in the neighborhood, this paragraph needs more fixes:

No, see the note above and the previous discussion.

>  In this method, H/L and X0/X1 is always in the same position.
>  This leads us to more speed and less memory.
>  Of course, the result of both methods is the same
>  because the only difference is the coefficient position.

Unless you want to say you've reviewed the code and
are completely confident that the original author meant
"the same" or "exactly the same" and not "quite similar"
then we need to leave the original wording alone.

-- PMM