[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] Extend qemu-ga's 'guest-info' command to exp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' |
Date: |
Tue, 08 Oct 2013 20:47:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 10/08/2013 08:37 PM, Mark Wu wrote:
> Now we have several qemu-ga commands not returning response on success.
> It has been documented in qga/qapi-schema.json already. This patch exposes
> the 'success-response' flag by extending 'guest-info' command. With this
> change, the clients can handle the command response more flexibly.
>
> Signed-off-by: Mark Wu <address@hidden>
> ---
> v5:
> Fix a tab indent and rebase
> v4:
> Add signature of qmp_has_success_response per Michael.
> v3:
> 1. treat cmd->options as a bitmask instead of single option (per Eric)
> 2. rebase on the patch " Add interface to traverse the qmp command list
> by QmpCommand" to avoid the O(n2) problem (per Eric and Michael)
> v2:
> add the notation 'since 1.7' to the option 'success-response'
> (per Eric Blake's comments)
>
> include/qapi/qmp/dispatch.h | 1 +
> qapi/qmp-registry.c | 5 +++++
> qga/commands.c | 1 +
> qga/qapi-schema.json | 5 ++++-
> 4 files changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature