[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info |
Date: |
Mon, 30 Sep 2013 11:19:39 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
On 09/23/2013 06:09 AM, Max Reitz wrote:
> Add a test for the additional information now provided by qemu-img info
> when used on qcow2 images.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/065 | 72
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/065.out | 22 ++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 95 insertions(+)
> create mode 100755 tests/qemu-iotests/065
> create mode 100644 tests/qemu-iotests/065.out
This patch only tests human output, not JSON.
> +# creator
> address@hidden
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
Not your fault (copy-and-paste from other tests), but as long as we are
requiring bash, $PWD is much faster than `pwd`, and $() is nicer than ``
where we don't have even faster shortcuts like $PWD.
> +=== Testing qcow2 image with -o compat=0.10 ===
> +
> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> +Format specific information:
> +compat: 0.10
Should we be indenting the human output, to make it obvious how many
remaining fields are being output as a result of format specific
information?
I'm still not happy with 5/6 in its current form, but can live with this
patch as-is if we don't bother with testing JSON form. Does 5/6 even
need to worry about stripping JSON form, if you aren't going to test
JSON form? Depending on the answer to that question:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 0/6] Provide additional info through qemu-img info, Max Reitz, 2013/09/23
- [Qemu-devel] [PATCH v5 2/6] block: Add bdrv_get_specific_info, Max Reitz, 2013/09/23
- [Qemu-devel] [PATCH v5 4/6] qcow2: Add support for ImageInfoSpecific, Max Reitz, 2013/09/23
- [Qemu-devel] [PATCH v5 3/6] block/qapi: Human-readable ImageInfoSpecific dump, Max Reitz, 2013/09/23
- [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Discard specific info in _img_info, Max Reitz, 2013/09/23
- [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info, Max Reitz, 2013/09/23
- Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info,
Eric Blake <=
- [Qemu-devel] [PATCH v5 1/6] qapi: Add ImageInfoSpecific type, Max Reitz, 2013/09/23