[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet |
Date: |
Mon, 30 Sep 2013 18:58:44 +0300 |
On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote:
> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto:
> > I was really only talking about q35 here.
> > I thought it's ugly that users can control intcap
> > directly. Can object_set_property be used after
> > qdev_try_create?
>
> Yes, after that and before qdev_init. This is how Ping Fan is doing
> PIIX right now.
>
> > PIIX has another issue:
> > the default value in hpet is really Q35 specific,
> > that's also kind of ugly, isn't it?
>
> Yeah, perhaps it is. So are you suggesting the default to be 4 (GSI2 only)?
>
> Paolo
I suggest it fails unless caller set the property.
- Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS, (continued)
- [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Liu Ping Fan, 2013/09/11
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Michael S. Tsirkin, 2013/09/28
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, liu ping fan, 2013/09/28
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Michael S. Tsirkin, 2013/09/29
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, liu ping fan, 2013/09/30
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Paolo Bonzini, 2013/09/30
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Michael S. Tsirkin, 2013/09/30
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet, Paolo Bonzini, 2013/09/30
- Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH v5 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx, Liu Ping Fan, 2013/09/11
[Qemu-devel] [PATCH v5 4/5] PC: differentiate hpet's interrupt capability on piix and q35, Liu Ping Fan, 2013/09/11
[Qemu-devel] [PATCH v5 5/5] PC-1.6: add compatibility for hpet intcap on pc-q35-1.6, Liu Ping Fan, 2013/09/11
Re: [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet, Paolo Bonzini, 2013/09/12
Re: [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet, liu ping fan, 2013/09/25