qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
Date: Mon, 30 Sep 2013 18:58:44 +0300

On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote:
> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto:
> > I was really only talking about q35 here.
> > I thought it's ugly that users can control intcap
> > directly. Can object_set_property be used after
> > qdev_try_create?
> 
> Yes, after that and before qdev_init.  This is how Ping Fan is doing
> PIIX right now.
> 
> > PIIX has another issue:
> > the default value in hpet is really Q35 specific,
> > that's also kind of ugly, isn't it?
> 
> Yeah, perhaps it is.  So are you suggesting the default to be 4 (GSI2 only)?
> 
> Paolo

I suggest it fails unless caller set the property.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]