Re: [Qemu-devel] [PATCH v5 00/23] qemu: generate acpi tables for the guest

[Gerd Hoffmann]

  Hi,

> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 1ba86d0..d1ccdf7 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -961,8 +961,8 @@ static void acpi_build_update(void *build_opaque, 
> uint32_t offset)
>      if (build_state->mcfg_base) {
>          AcpiMcfgAllocation *a;
>          mcfg_base = qint_get_int(build_state->mcfg_base);
> +        assert(build_state->mcfg_size);
>          mcfg_size = qint_get_int(build_state->mcfg_size);
> -        assert(mcfg_size);
>  
>          a = ACPI_BUILD_STATE_PTR(build_state, off_mcfg_allocation,
>                                   AcpiMcfgAllocation);

Well, that fixes the assert, but it still isn't working correctly.  No
mcfg table in acpi, even though the mcfg bar is programmed correctly.

Seeing this with both seabios+coreboot.

cheers,
  Gerd