[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command |
Date: |
Tue, 24 Sep 2013 13:10:59 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.09.2013 um 12:41 hat Paolo Bonzini geschrieben:
> Il 20/09/2013 16:01, Benoît Canet ha scritto:
> >> > + if (error_is_set(&local_err)) {
> >> > + error_propagate(errp, local_err);
> >> > + goto fail;
> > There is nothing to execute between error_propagate and fail: maybe we could
> > get rid of the goto.
>
> Or perhaps of the "else".
Indeed, that looks a bit strange now... It doesn't survive until the end
of the series anyway, but I can remove it here. (The else branch has a
useless goto as well, but I'd prefer to leave it there in case new code
is added later - it's easy to miss when a goto becomes necessary.)
Kevin
- [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation, (continued)
- [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation, Kevin Wolf, 2013/09/20
- [Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init(), Kevin Wolf, 2013/09/20
- [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command, Kevin Wolf, 2013/09/20
- Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command, Eric Blake, 2013/09/20
- Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command, Fam Zheng, 2013/09/24
- Re: [Qemu-devel] [PATCH 04/17] blockdev: 'blockdev-add' QMP command, Paolo Bonzini, 2013/09/24
- [Qemu-devel] [PATCH 07/17] blockdev: Move parsing of 'media' option to drive_init, Kevin Wolf, 2013/09/20
- [Qemu-devel] [PATCH 08/17] blockdev: Move parsing of 'if' option to drive_init, Kevin Wolf, 2013/09/20