[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name |
Date: |
Mon, 23 Sep 2013 15:32:08 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 12, 2013 at 10:51:48AM +0200, Paolo Bonzini wrote:
> Il 12/09/2013 10:38, Stefan Hajnoczi ha scritto:
> > On Tue, Sep 10, 2013 at 06:40:04PM +0200, Paolo Bonzini wrote:
> >> The UUID is unique even across multiple hosts, thus it is
> >> better than a VM name even if it is less user-friendly.
> >>
> >> Signed-off-by: Paolo Bonzini <address@hidden>
> >> ---
> >> block/iscsi.c | 23 ++++++++++++++++-------
> >> include/sysemu/sysemu.h | 2 ++
> >> stubs/Makefile.objs | 1 +
> >> stubs/uuid.c | 12 ++++++++++++
> >> 4 files changed, 31 insertions(+), 7 deletions(-)
> >> create mode 100644 stubs/uuid.c
> >
> > Will changing the initiator name break existing setups/ACLs?
>
> The username for authentication is separate from the initiator name.
>
> It could break persistent reservations, but there is a workaround
> (specify the initiator name manually through "-iscsi"). I'll make sure
> to document this in the release changelog.
>
> Does it look good?
It's already merged but for the record, I'm happy with the patch.
Stefan