Re: [Qemu-devel] [PATCH] Ensure PCIR is aligned to 4 bytes

[Sebastian Herbszt]

Brad Smith wrote:
> On 19/09/13 12:53 PM, Sebastian Herbszt wrote:
> > Brad Smith wrote:
> >> On 20/01/13 1:12 PM, David Woodhouse wrote:
> >>> The PCI Firmware Specification apparently requires that the PCI
> >>> Data Structure be DWORD-aligned. The implementation in OVMF also
> >>> requires this, so vgabios ROMs don't work there. With this fixed,
> >>> I can now initialise the VGA ROM from EFI, and EFI can display
> >>> using INT 10h services.
> >>>
> >>> --- vgabios-0.6c/vgabios.c.orig   2013-01-20
> >>> 11:33:36.138548472 -0600 +++ vgabios-0.6c/vgabios.c
> >>> 2013-01-20 11:36:26.060270163 -0600 @@ -204,6 +204,7 @@
> >>> vgabios_website: .byte    0x00
> >>>
> >>>    #ifdef PCIBIOS
> >>> +.align 4 // DWORD alignment required by PCI Firmware
> >>> Specification vgabios_pci_data:
> >>>    .ascii "PCIR"
> >>>    #ifdef CIRRUS
> >>
> >> We have had this in the OpenBSD port of QEMU for awhile now. Is it
> >> possible to have this reviewed and commited?
> >
> > This change was commited to upstream vgabios back in February [1].
> 
> But that has not resulted in it being brought into QEMU.

Gerd, Anthony, care to update QEMU's vgabios repository [1] with
changes from upstream CVS repository [2]?

[1] http://git.qemu.org/?p=vgabios.git
[2] http://cvs.savannah.gnu.org/viewvc/?root=vgabios

Sebastian