[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback c
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] Serious bugs in the handling of writeback caching |
Date: |
Fri, 20 Sep 2013 19:28:13 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 19, 2013 at 06:48:52PM +0200, Paolo Bonzini wrote:
> The first bug is simply that in 1.6.0 the default was changed by mistake
> to cache=unsafe. This affects all block drivers. It is fixed in the
> first patch.
>
> The second is that Linux guests that support the CONFIG_WCE option were
> mistaken into thinking that caching was writethrough, and thus did not
> send any flush. The bug is in QEMU, and is fixed by the second patch.
>
> Paolo Bonzini (2):
> blockdev: do not default cache.no-flush to true
> virtio-blk: do not relay a previous driver's WCE configuration to the
> current
>
> blockdev.c | 2 +-
> hw/block/virtio-blk.c | 8 ++++++--
> include/hw/virtio/virtio-blk.h | 1 +
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> --
> 1.8.3.1
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan