qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] migration: ram_handle_compressed


From: Michael R. Hines
Subject: Re: [Qemu-devel] [PATCH] migration: ram_handle_compressed
Date: Wed, 18 Sep 2013 08:30:42 -0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 09/18/2013 06:07 AM, Isaku Yamahata wrote:
ram_handle_compressed() should be aware size > TARGET_PAGE_SIZE
migration-rdma can call it with larger size.

Signed-off-by: Isaku Yamahata <address@hidden>
---
  arch_init.c |   21 ++++++++++++++-------
  1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index e47e139..64c81b0 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -844,15 +844,22 @@ static inline void *host_from_stream_offset(QEMUFile *f,
   */
  void ram_handle_compressed(void *host, uint8_t ch, uint64_t size)
  {
-    if (ch != 0 || !is_zero_page(host)) {
-        memset(host, ch, size);
+    uint64_t pagesize = getpagesize();
+    while (size > 0) {
+        uint64_t length = MIN(pagesize, size);
+
+        if (ch !=0 || buffer_find_nonzero_offset(host, length) != length) {
+            memset(host, ch, length);
  #ifndef _WIN32
-        if (ch == 0 &&
-            (!kvm_enabled() || kvm_has_sync_mmu()) &&
-            getpagesize() <= TARGET_PAGE_SIZE) {
-            qemu_madvise(host, TARGET_PAGE_SIZE, QEMU_MADV_DONTNEED);
-        }
+            if (ch == 0 &&
+                (!kvm_enabled() || kvm_has_sync_mmu()) && pagesize <= length) {
+                qemu_madvise(host, size, QEMU_MADV_DONTNEED);
+            }
  #endif
+        }
+
+        size -= length;
+        host += length;
      }
  }


What is the reason for breaking the madvise() into smaller pieces?

- Michael




reply via email to

[Prev in Thread] Current Thread [Next in Thread]