Re: [Qemu-devel] [PATCH v9 5/8] module: implement module loading

[Daniel P. Berrange]

On Fri, Sep 13, 2013 at 05:59:13PM +0800, Fam Zheng wrote:
> +void module_load(module_load_type type)
> +{
> +#ifdef CONFIG_MODULES
> +    const char *path;
> +    char *fname = NULL;
> +    const char **mp;
> +    const char *module_whitelist[] = {
> +        CONFIG_MODULE_WHITELIST
> +    };
> +
> +    if (!g_module_supported()) {
> +        return;
> +    }
> +
> +    switch (type) {
> +    case MODULE_LOAD_BLOCK:
> +        path = CONFIG_MODDIR "/block/";
> +        break;
> +    case MODULE_LOAD_UI:
> +        path = CONFIG_MODDIR "/ui/";
> +        break;
> +    case MODULE_LOAD_NET:
> +        path = CONFIG_MODDIR "/net/";
> +        break;
> +    default:
> +        return;
> +    }
> +
> +    for (mp = &module_whitelist[0]; *mp; mp++) {
> +        fname = g_strdup_printf("%s%s" HOST_DSOSUF, path, *mp);
> +        module_load_file(fname);
> +        g_free(fname);
> +    }

You need a separate whitelist for block, ui, net, etc. This code just
spews errors to stderr.

Failed to open module file 
/home/berrange/usr/qemu-git-mod/lib/qemu/ui/iscsi.so: cannot open shared object 
file: No such file or directory
Failed to open module file /home/berrange/usr/qemu-git-mod/lib/qemu/ui/curl.so: 
cannot open shared object file: No such file or directory
Failed to open module file /home/berrange/usr/qemu-git-mod/lib/qemu/ui/rbd.so: 
cannot open shared object file: No such file or directory
Failed to open module file 
/home/berrange/usr/qemu-git-mod/lib/qemu/ui/gluster.so: cannot open shared 
object file: No such file or directory
Failed to open module file /home/berrange/usr/qemu-git-mod/lib/qemu/ui/ssh.so: 
cannot open shared object file: No such file or directory
Failed to open module file 
/home/berrange/usr/qemu-git-mod/lib/qemu/net/iscsi.so: cannot open shared 
object file: No such file or directory
Failed to open module file 
/home/berrange/usr/qemu-git-mod/lib/qemu/net/curl.so: cannot open shared object 
file: No such file or directory
Failed to open module file /home/berrange/usr/qemu-git-mod/lib/qemu/net/rbd.so: 
cannot open shared object file: No such file or directory
Failed to open module file 
/home/berrange/usr/qemu-git-mod/lib/qemu/net/gluster.so: cannot open shared 
object file: No such file or directory
Failed to open module file /home/berrange/usr/qemu-git-mod/lib/qemu/net/ssh.so: 
cannot open shared object file: No such file or directory

was this even tested before being posted ?

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|