[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading functio
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function |
Date: |
Wed, 11 Sep 2013 11:46:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 09/11/2013 08:48 AM, Daniel P. Berrange wrote:
> We know the precise list of valid modules when building QEMU,
> so IMHO, this should just explicitly load each known module
> name, and *not* readdir. Also it should do something along the
> lines suggested their of poisoning exported symbols with a
> build hash to guarantee the modules loaded match the original
> binary and that the symbols change on every rebuild.
We need not mangle the symbols, which could be complicated to
actually implement, and irritating to work around within gdb.
We could instead just add the build-id as a variable within
the module. Read and compare the build-id after loading the
module; unload and reject on mismatch.
r~
- Re: [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs, (continued)
[Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO, Fam Zheng, 2013/09/11
[Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Fam Zheng, 2013/09/11
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Daniel P. Berrange, 2013/09/11
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Alex Bligh, 2013/09/11
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Fam Zheng, 2013/09/11
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Michael Tokarev, 2013/09/12
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Daniel P. Berrange, 2013/09/12
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Eric Blake, 2013/09/12
- Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function, Daniel P. Berrange, 2013/09/12
[Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules, Fam Zheng, 2013/09/11
[Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install", Fam Zheng, 2013/09/11